Fix alcatel_sros gnss ports with less columns - #2343
Merged
Conversation
bennnnnnnn
requested review from
itdependsnetworks,
jmcgill298,
jvanderaa,
matt852 and
mjbear
as code owners
August 11, 2026 10:06
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
mjbear
changed the title
mjbear
approved these changes
Aug 16, 2026
matt852
reviewed
Aug 20, 2026
matt852
left a comment
matt852
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall. 1 nit question posted on white space.
| 10/2/c23 Down Down conn | ||
| 10/2/c24 Down Down conn | ||
| A/1 Up Yes Up 1514 1514 - netw null xcme MDI | ||
| A/gnss Down No Down gnss |
Contributor
There was a problem hiding this comment.
Are the trailing white spaces at the end of line 237 intentional or accidental? It looks like the only line in this file with trailing white space.
Contributor
Author
There was a problem hiding this comment.
Good catch! Copy/paste error 😅 I've corrected it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix to support gnss pseudo ports